Redesigned room preview bar#2925
Conversation
so we can reuse it in room preview bar
jryans
left a comment
jryans
left a comment
There was a problem hiding this comment.
Great, thanks for working on this! 😁 Lots of changes, but each commit seemed to make sense to me, and the look seems to match Zeplin as well.
| _viewUser: function(userId, action) { | ||
| // Wait for the first sync so that `getRoom` gives us a room object if it's | ||
| // in the sync response | ||
| const waitFor = this.firstSyncPromise ? |
| this.setState({currentUserId: userId}); | ||
| this._setPage(PageTypes.UserView); | ||
| }); | ||
| this._viewUser(userId, params.action); |
There was a problem hiding this comment.
Should we change to dispatch view_user_info here instead of calling directly? It looks like many of the other branches dispatch actions, so just wondering it would make sense to follow that pattern.
| onRejectClick: PropTypes.func, | ||
| onForgetClick: PropTypes.func, | ||
| onSignInClick: PropTypes.func, | ||
| onSignUpClick: PropTypes.func, |
There was a problem hiding this comment.
Should we add loading, busy, room_alias, etc. to the propTypes somewhere? It seems like there are quite a few unchecked props.
There was a problem hiding this comment.
Yes, forgot about these! Ftr: room_alias was a typo, and busy is state, added the others!
|
should be good for another look |
|
Per request from @nadonomy, added hiding of the right panel when previewing a room without invite (e.g. viewing a world readable room after clicking it in the room directory). The member list is always empty, so no reason to show it. |
|
Oops, the status bar is squeezing itself below it still |
|
|
jryans
left a comment
jryans
left a comment
There was a problem hiding this comment.
Looks great, thanks for working on this! 😁
2 participants
element-hq/element-web#7576
Requires: