Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Enable CIDER composer by default#3519

Merged
t3chguy merged 2 commits into
developfrom
travis/enable-cider
Oct 4, 2019
Merged

Enable CIDER composer by default#3519
t3chguy merged 2 commits into
developfrom
travis/enable-cider

Conversation

@turt2live
Copy link
Copy Markdown
Member

@turt2live turt2live commented Oct 4, 2019

Also convert the setting to a watched setting to apply in realtime.

Paired with element-hq/element-web#11047

Also convert the setting to a watched setting to apply in realtime.
@turt2live turt2live added the X-Release-Blocker This affects the current release cycle and must be solved for a release to happen label Oct 4, 2019
turt2live added a commit to element-hq/element-web that referenced this pull request Oct 4, 2019
@turt2live turt2live requested a review from a team October 4, 2019 05:23
Copy link
Copy Markdown
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

Comment thread src/components/structures/RoomView.js Outdated
Comment thread src/settings/Settings.js Outdated
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy t3chguy requested a review from a team October 4, 2019 09:15
@bwindels bwindels removed the X-Release-Blocker This affects the current release cycle and must be solved for a release to happen label Oct 4, 2019
@bwindels bwindels requested review from bwindels and removed request for a team October 4, 2019 09:16
Copy link
Copy Markdown
Contributor

@bwindels bwindels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@t3chguy
Copy link
Copy Markdown
Member

t3chguy commented Oct 4, 2019

Blocked on updated e2e tests

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants