This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Slash Command improvements around sending messages with leading slash#3893
Merged
Conversation
foldleft
reviewed
Jan 22, 2020
foldleft
approved these changes
Jan 22, 2020
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#11580
Fixes element-hq/element-web#4630
Allows
//to send messages starting with/(///for//and so forth)Allows changing a command to a non-command for in the case of typing
/mebut then editing it to be*/me*, previously this would just blank out the composer without any say why.When entering an unknown command, e.g
/test, previously a modal came up telling you that the command is unknown and your composer got wiped out, now your composer is retained unless you select the new option on the modal toSend as messageThe
//case comes with Tests :D