This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Add an override for the theme#4014
Merged
Merged
Conversation
So we can force the light theme on unthemeable pages like the login & complete security page. Fixes element-hq/element-web#12149 Fixes element-hq/element-web#12157
turt2live
approved these changes
Jan 31, 2020
Member
turt2live
left a comment
turt2live
left a comment
There was a problem hiding this comment.
lgtm either way, though the setter choice feels odd
Collaborator
|
Please also file an issue to remove all the auth page CSS that overrides colours to light theme (but let's not actually do that until after FOSDEM). |
turt2live
approved these changes
Jan 31, 2020
This was referenced Nov 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So we can force the light theme on unthemeable pages like the login
& complete security page.
Fixes element-hq/element-web#12149
Fixes element-hq/element-web#12157