This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Remove feature_cross_signing#4655
Merged
Merged
Conversation
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Member
Author
|
@matrix-org/design do we want |
turt2live
approved these changes
Jun 3, 2020
Member
turt2live
left a comment
turt2live
left a comment
There was a problem hiding this comment.
Generally looks good to me - thanks!
Contributor
We'll catch this when we implement Settings in earnest so I'm ambivalent on this for now. |
nadonomy
approved these changes
Jun 3, 2020
dbkr
added a commit
that referenced
this pull request
Jun 3, 2020
#4655 removed the check for cross-signing account data where the cross-signing labs flag was enabled if you had an existing cross-signing setup. This also sent the user to the 'complete security' view rather than the 'E2E Setup' view though, which meant new logins should always see the E2E setup screen (ie. be prompted to upgrade encryption). NB. We need to change this check for SSSS keys in account data (element-hq/element-web#13894) but we should put this back the way it was in the meantime. Regressed in #4655
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#11219