This repository was archived by the owner on Sep 11, 2024. It is now read-only.
UI for verifiable forwarded events#5117
Closed
tulir wants to merge 5 commits into
Closed
Conversation
Signed-off-by: Tulir Asokan <tulir@maunium.net>
Signed-off-by: Tulir Asokan <tulir@maunium.net>
This was referenced Aug 14, 2020
Merged
MadLittleMods
added
the
Z-Community-PR
| /> | ||
| </blockquote>; | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
For easier review and reference, let's add some before/after screenshots in the PR description for the various pieces here.
MadLittleMods
added
the
T-Enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the client side of MSC2730: sending forwards with the new endpoint and rendering validated forwards properly.
For sending forwards, the old forward button is replaced. The rendering is currently a very basic reply-like rendering, but it should probably be more distinct based on the designs in element-hq/element-web#14690. I might implement the better designs in this PR or a future one.
MSC: matrix-org/matrix-spec-proposals#2730
Synapse PR: matrix-org/synapse#8078
matrix-js-sdk PR: matrix-org/matrix-js-sdk#1439
Signed-off-by: Tulir Asokan <tulir@maunium.net>
Here's what your changelog entry will look like:
✨ Features