This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Migrate RoomView and RoomContext to Typescript#5175
Merged
Conversation
turt2live
suggested changes
Sep 8, 2020
Member
Author
|
Parking this due to risk for post-RC |
turt2live
approved these changes
Sep 8, 2020
Member
turt2live
left a comment
turt2live
left a comment
There was a problem hiding this comment.
lgtm for after the RC, assuming the tests can be made happy enough
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subset of #5167