This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Add a customisation point for widget permissions and fix amnesia issues#5439
Merged
Conversation
The "remember my selection" option wasn't working because the `missing` set still included the approved permission. Solution: remove it from `missing`. The customisation point is to allow forks to change which widgets get which additional capabilities dependent on their own rules.
jryans
approved these changes
Nov 24, 2020
Collaborator
jryans
left a comment
jryans
left a comment
There was a problem hiding this comment.
Thanks, looks good to me! 😄
| // them all as optional. This allows customisers to only define and export the | ||
| // customisations they need while still maintaining type safety. | ||
| export interface IWidgetPermissionCustomisations { | ||
| preapproveCapabilities?: typeof preapproveCapabilities; |
Collaborator
There was a problem hiding this comment.
Ah, a good use of typeof indeed. 😄
This was referenced Jan 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "remember my selection" option wasn't working because the
missingset still included the approved permission. Solution: remove it frommissing.The customisation point is to allow forks to change which widgets get which additional capabilities dependent on their own rules.