This repository was archived by the owner on Sep 11, 2024. It is now read-only.
[Labs] Refresh UI for keybindings and prep for customisable keybindings#5758
Closed
SimonBrandner wants to merge 28 commits into
Closed
[Labs] Refresh UI for keybindings and prep for customisable keybindings#5758SimonBrandner wants to merge 28 commits into
SimonBrandner wants to merge 28 commits into
Conversation
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
TravisR will fix this nightmare Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
SimonBrandner
changed the title
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
jryans
changed the title
germain-gg
reviewed
Apr 9, 2021
Contributor
germain-gg
left a comment
germain-gg
left a comment
There was a problem hiding this comment.
Looks like a great PR to me! Thank you for the contribution
Going to wait for Travis' comment and add that back to the review queue as it's probably best if one other member of the team lay their eyes on this before we merge it
Co-authored-by: Germain <germain@souquet.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
t3chguy
reviewed
Apr 13, 2021
t3chguy
reviewed
Apr 13, 2021
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
turt2live
requested review from
t3chguy and
turt2live
and removed request for
turt2live
SimonBrandner
added
the
T-Enhancement
Contributor
Author
|
I am going to close this as the PR is big and outdated by now. That makes it hard to continue working on it and review it. I instead choose a less radical approach of slowly moving toward customizable keybindings, first PR that does that is #7198 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new UI for keybindings hidden under labs. It also adds keybinding setting entries. Those will be useful for customizable keybindings in later PRs.
Well, this is my biggest PR yet. Let's see how badly it goes 😅
Note: The design review can be skipped here since this is behind labs.
Element-web PR