This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Add view source button on error boundary for messages#5794
Closed
panagiotis-c wants to merge 4 commits into
Closed
Add view source button on error boundary for messages#5794panagiotis-c wants to merge 4 commits into
panagiotis-c wants to merge 4 commits into
Conversation
turt2live
approved these changes
Mar 26, 2021
Member
turt2live
left a comment
turt2live
left a comment
There was a problem hiding this comment.
code looks fine, though design will probably want to take a look too (iirc this was designed as shown)
Member
|
I completely forgot about this PR and ended up re-implementing it myself, sorry. #7537 does the same thing but only when the developer mode flag is set (introduced after this PR was opened), thus making it not require design approval. Thank you for the contribution, and apologies for forgetting about it 😬 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#15409
We could not want this, though, because I suppose errors will not happen at all, and you can use the console or the logs to debug the error.
I added a second link here. We could also do it with a context menu like on normal messages.
Signed-off-by: Panagiotis Chalimourdas panagiotis4531@gmail.com