This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Try putting room list handling behind a lock#6024
Merged
Merged
Conversation
Some of the logs relating to room list corruption appear to be badly timed race conditions so we'll try to linearize them here.
t3chguy
approved these changes
May 14, 2021
Member
t3chguy
left a comment
t3chguy
left a comment
There was a problem hiding this comment.
looks plausible - github really butchered that diff though
Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of the logs relating to room list corruption appear to be badly timed race conditions so we'll try to linearize them here.
The diff looks complicated, but it's just wrapping
handleRoomUpdatein atry/finally.I have about a 4/10 confidence on this working, only because I can't reproduce the corruption by hand before or after the change.