[WIP] Rewrite MFileBody#6223
Conversation
SimonBrandner
force-pushed
the
feature/download-button/16668
branch
2 times, most recently
from
06dbfd8 to
3045ab7
Compare
|
How is this supposed to work for encrypted files, given that those currently require two clicks on the hyperlink to decrypt and then download? I just tried downloading an encrypted file, and it looks like it downloaded in an encrypted form. |
It should decrypt the file and then download it but as I say in the PR description, this is very rushed, so it doesn't work :P |
|
Makes sense, though not sure if you're aware but you might run into some problems with that approach: element-hq/element-web#16087 (comment) |
SimonBrandner
force-pushed
the
feature/download-button/16668
branch
2 times, most recently
from
7fc3f7f to
a6eb025
Compare
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
SimonBrandner
force-pushed
the
feature/download-button/16668
branch
from
a6eb025 to
a6950f3
Compare
|
Just FYI that I'll be in this same area this week to move and fix the download button, which includes potential architecture changes. |
|
Closing in favour of #6386 |
3 participants
Fixes element-hq/element-web#16668
This is a very rushed attempt to fix the above-mentioned issue.