This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Convert MessagePanel, TimelinePanel, ScrollPanel, and more to Typescript#6243
Merged
Conversation
This was referenced Jun 23, 2021
… t3chguy/ts/8 � Conflicts: � src/components/structures/AutoHideScrollbar.tsx
turt2live
approved these changes
Jun 25, 2021
Member
turt2live
left a comment
turt2live
left a comment
There was a problem hiding this comment.
the diff overall is massive, so I probably missed something, but this looks good to go. Would recommend landing nowish to make the most of the pre-RC era.
Collaborator
|
Perhaps obvious, but this should definitely wait until after the RC branches tomorrow. |
Collaborator
|
Very impressive work all around, quite excited to have these core bits in TS! 😄 |
… t3chguy/ts/8 � Conflicts: � src/components/structures/MessagePanel.tsx � src/components/structures/TimelinePanel.tsx
… t3chguy/ts/8 � Conflicts: � src/components/structures/MessagePanel.tsx � src/components/structures/ScrollPanel.tsx � src/components/structures/TimelinePanel.tsx � src/components/views/elements/ErrorBoundary.tsx � src/components/views/elements/EventListSummary.tsx � src/components/views/messages/TileErrorBoundary.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires matrix-org/matrix-js-sdk#1753