This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Don't show Copy Link for DMs#6400
Closed
novocaine wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
Change of plan; instead, I'm going to rename this to make it less confusing, but retain the functionality for DMs |
Contributor
|
Wouldn't it be better to hide this for all invite-only rooms? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid showing the Copy Link menu item (#6374) for DMs, as in that context the menu item is confusing - users might understand its for copying a link to a person, but its actually a link to a 1:1 room that it's unlikely you'd want to share.