Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

TypeScript migration for auth components#6412

Merged
germain-gg merged 18 commits into
developfrom
gsouqet/ts-migration-1
Jul 21, 2021
Merged

TypeScript migration for auth components#6412
germain-gg merged 18 commits into
developfrom
gsouqet/ts-migration-1

Conversation

@germain-gg
Copy link
Copy Markdown
Contributor

@germain-gg germain-gg commented Jul 20, 2021

No description provided.

@germain-gg germain-gg requested a review from a team July 20, 2021 06:57
Comment thread src/async-components/views/dialogs/eventindex/DisableEventIndexDialog.tsx Outdated
Copy link
Copy Markdown
Contributor

@SimonBrandner SimonBrandner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully, it's possible and won't result in test failures

Comment thread src/components/views/auth/AuthHeader.tsx Outdated
Comment thread src/components/views/auth/AuthPage.tsx Outdated
Comment thread src/components/views/auth/CountryDropdown.tsx Outdated
Comment thread src/components/views/auth/LanguageSelector.tsx Outdated
Comment thread src/components/views/auth/Welcome.tsx Outdated
Comment thread src/@types/global.d.ts Outdated
Comment thread src/components/views/auth/CountryDropdown.tsx Outdated
@t3chguy
Copy link
Copy Markdown
Member

t3chguy commented Jul 20, 2021

Also thanks @SimonBrandner for first round of review

@SimonBrandner
Copy link
Copy Markdown
Contributor

Also thanks @SimonBrandner for first round of review

I wouldn't really call it a review - I just couldn't help myself, sdk.getComponents are painful to look at 😄

Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
@germain-gg germain-gg requested a review from t3chguy July 20, 2021 16:19
Comment thread src/@types/global.d.ts Outdated
Copy link
Copy Markdown
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

:shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit:

@germain-gg germain-gg merged commit ae60692 into develop Jul 21, 2021
@germain-gg germain-gg deleted the gsouqet/ts-migration-1 branch July 21, 2021 07:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants