Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Clean up voice messages code#6453

Merged
turt2live merged 3 commits into
developfrom
travis/voice-messages/code-cleanup-1
Jul 23, 2021
Merged

Clean up voice messages code#6453
turt2live merged 3 commits into
developfrom
travis/voice-messages/code-cleanup-1

Conversation

@turt2live
Copy link
Copy Markdown
Member

@turt2live turt2live commented Jul 22, 2021

Fixes element-hq/element-web#18161
Fixes element-hq/element-web#18131

Review with element-hq/element-web#18187


Reviewer: This is reviewable commit-by-commit.


Notes: none
element-web notes: none

@turt2live turt2live added Sponsored T-Task Refactoring, enabling or disabling functionality, other engineering tasks labels Jul 22, 2021
@turt2live turt2live requested a review from a team July 22, 2021 18:18
@turt2live
Copy link
Copy Markdown
Member Author

I think the end-to-end failure here is a failure to match branches.

Copy link
Copy Markdown
Contributor

@germain-gg germain-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 👏

@turt2live turt2live merged commit 2c4ab50 into develop Jul 23, 2021
@turt2live turt2live deleted the travis/voice-messages/code-cleanup-1 branch July 23, 2021 15:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Sponsored T-Task Refactoring, enabling or disabling functionality, other engineering tasks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AudioPlayer and RecordingPlayback are basically the same component Voice messages: react-sdk src/voice should be src/audio

2 participants