This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Migrate StickerPicker to TypeScript#6677
Merged
Merged
Conversation
germain-gg
added
the
T-Task
SimonBrandner
approved these changes
Aug 25, 2021
turt2live
approved these changes
Aug 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of element-hq/element-web#18533
Splitting into its own PR to generate a smaller diff to review at the end.
The process highlighted a couple of bugs in the
StickerPicker.This change is marked as an internal change (Task), so will not be included in the changelog.
Preview: https://612648da9d29b7c3b1fc18cd--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.