Use disptacher to answer/reject calls in call tiles#6705
Conversation
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
github-actions
Bot
added
the
T-Task
Palid
left a comment
Palid
left a comment
There was a problem hiding this comment.
LGTM, the two comments are a minor thing, but it wouldn't hurt to address them!
| } | ||
|
|
||
| private get roomId(): string { | ||
| return [...this.events][0]?.getRoomId(); |
There was a problem hiding this comment.
Are we always 100% certain we have at least one element in this.events? Seems from my short code analysis that this case should never happen, but could we add an additional check for it, just to be sure? Same would go for callId. Otherwise LGTM.
There was a problem hiding this comment.
We should always have at least one event, but I've added some ? and made the return type into string | undefined, hopefully, it's better this way?
There was a problem hiding this comment.
We should also probably have some null-checks though those should be in the CallHandler. I am going to do some more refactoring in that area, so this is one of the things I will look into
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
SimonBrandner
added
the
X-Release-Blocker
|
Blocker so that #6691 isn't half-useless |
3 participants
Fixes element-hq/element-web#18825
Type: task
This change is marked as an internal change (Task), so will not be included in the changelog.
Preview: https://6130f3e40a73a5fcda261486--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.