Replace emoticons when sending a message rather than when typing#6718
Replace emoticons when sending a message rather than when typing#6718SimonBrandner wants to merge 2 commits into
Conversation
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
turt2live
left a comment
There was a problem hiding this comment.
The code looks fine, though the behaviour change is fairly dramatic. It's actually quite annoying when other apps (Messenger, certain email clients, etc) replace on send as what you carefully curated your keystrokes for gets mangled by the app, losing confidence that what you type is what will be sent.
In the short term, there's an advanced (and confusing) setting for autocomplete delay: I'd try raising that a bit and seeing how that feels so we can consider possibly changing the default value there.
I tend to prefer this since it's consistent with the emoticon at the end of the line. See element-hq/element-web#18833 (comment). I can create a PR that does the alternative mentioned in the issue.
Sorry, I don't think this relates much. Since the autocomplete changes we never autocomplete emoticons ( |
Fixes element-hq/element-web#18833
Type: enhancement
This is a Discord-like behaviour
Peek.2021-08-31.18-45.mp4
Reasoning in in element-hq/element-web#18833 (comment)
Here's what your changelog entry will look like:
✨ Features
Preview: https://612e5de04963753ad92439b6--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.