Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Fix scroll being stuck at bottom#6751

Merged
dbkr merged 1 commit into
developfrom
dbkr/fix_stuck_scroll
Sep 7, 2021
Merged

Fix scroll being stuck at bottom#6751
dbkr merged 1 commit into
developfrom
dbkr/fix_stuck_scroll

Conversation

@dbkr
Copy link
Copy Markdown
Member

@dbkr dbkr commented Sep 6, 2021

The check for whether we're at the bottom or not allowed for a
difference of 1 to account for fractional scroll values, but
allowed the difference of exactly 1 too, meaning we'd consider
the timeline to be at the bottom if you were scrolled up by exactly
a single pixel. If your scrolling was set up to be precise enough and
the event handlers fired fast enough that they'd evaluate each time
you scrolled up by a single pixel, it would reset you back to the bottom
each time and you'd never be able to scroll up.

Fixes element-hq/element-web#18903


Here's what your changelog entry will look like:

🐛 Bug Fixes

Preview: https://613658bf512f0f3745178878--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.

Loading
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems X-Release-Blocker This affects the current release cycle and must be solved for a release to happen

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scrolling impossible when there are unread messages out of screen

2 participants