This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Get team_token from the RTS on login#676
Merged
Merged
Conversation
added 3 commits
February 3, 2017 14:34
Use the /login endpoint of the RTS to get the team token when the user has successfully logged in.
dbkr
reviewed
Feb 7, 2017
Member
dbkr
left a comment
dbkr
left a comment
There was a problem hiding this comment.
It's a shame that this makes it even easier to discover the team token for a team. In future what we could do is store the team token in user account data.
| return false; | ||
| } | ||
| } | ||
| const RtsClient = require("./RtsClient"); |
Member
There was a problem hiding this comment.
Shouldn't this be at the top as an import?
| window.addEventListener('resize', this.handleResize); | ||
| this.handleResize(); | ||
|
|
||
| Lifecycle.initRtsClient(this.props.config.teamServerConfig.teamServerURL); |
Member
There was a problem hiding this comment.
Does this want to be done conditionally on there being a team server URL, as otherwise it looks like we'll always be creating a client but with an undefined URL.
Contributor
Author
|
Yes, if we want to be serious about isolating teams in a secure way then we'd need to support it from account data. |
dbkr
approved these changes
Feb 8, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the /login endpoint of the RTS to get the team token when the user has successfully logged in.