This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Group Calls (WIP)#6848
Closed
robertlong wants to merge 100 commits into
Closed
Conversation
Closed
SimonBrandner
suggested changes
Sep 21, 2021
Contributor
SimonBrandner
left a comment
SimonBrandner
left a comment
There was a problem hiding this comment.
There is one outstanding issue I see with this atm. The use of the GroupCallParticipants to display video elements is quite concerning to me. I find this solution quite ugly and not very scalable. I would very much prefer to stick to the current model of using CallFeeds and VideoFeed and AudioFeed components.
The are multiple reasons for this:
- Using
GroupCallParticipants feels like saying each participant is only sending one feed which isn't true - Using
CallFeeds matches the current way of doing things and allows us to reuse already existing code CallFeeds are screen-sharing friendlyCallFeeds are SFU friendly - with an SFU oneGroupCallParticipantmight be sending a bunch of streams, each one represented by aCallFeed(and corresponding components)
To be clear, I am not saying GroupCallParticipant should be removed or anything along those lines, I just think CallFeeds are better suited for being consumed by components for displaying video and playing audio
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
…react-sdk into robertlong/group-call
…react-sdk into robertlong/group-call
Author
|
I've moved these changes into element-call itself now. This PR is no longer necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting to implement group calls in Element. Will update these PR notes soon. This is following the work on Group Calls in matrix-js-sdk matrix-org/matrix-js-sdk#1902
This PR currently has no changelog labels, so will not be included in changelogs.
A reviewer can add one of:
T-Deprecation,T-Enhancement,T-Defect,T-Taskto indicate what type of change this is, or addType: [enhancement/defect/task]to the description and I'll add them for you.Preview: https://6173034b387f630f9c057210--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.