This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Request correct dimensions for image thumbnails#702
Closed
lukebarnard1 wants to merge 4 commits into
Closed
Conversation
added 3 commits
February 16, 2017 10:43
This is for when dynamic thumbnails are enabled on the home server, which will scale to exactly the dimensions provided.
Member
|
So, I think it's synapse that's at fault here rather than riot: the bug is matrix-org/synapse#1677 The idea is that the media repo worries about maintaining aspect ratio when scaling the image so the client doesn't have to. The client is only able to do this in this case because the other end has told it what it thinks the dimensions are which is not a terribly reliable mechanism, so the width and height specified by the client are a bounding box rather than exact dimensions. In any case, I would say that synapse's behaviour WRT aspect scaling should be consistent whether or not it has dynamic thumbnailing turned on or not. |
Contributor
Author
|
This has been made redundant by matrix-org/synapse#1945 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With dynamic thumbnails enabled:
Before changes:
After changes:
This is for when dynamic thumbnails are enabled on the home server, which will scale to exactly the dimensions provided. Synapse comments allude to clients specifying the correct width and height when requesting thumbnails.