This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Add basic linkify-matrix tests#7199
Merged
Merged
Conversation
t3chguy
added
the
T-Task
t3chguy
reviewed
Nov 25, 2021
t3chguy
suggested changes
Nov 25, 2021
t3chguy
approved these changes
Nov 26, 2021
| value: "bar.com", | ||
| }])); | ||
| }); | ||
| it('does not parse multiple room aliases in one string', () => { |
Member
There was a problem hiding this comment.
this test name doesn't seem to match the fixture
Member
|
Hmm, I didn't see that auto-merge was enabled. @Palid could you include a fix for the test name in the PR for upgrading linkify whenever you do it please |
Contributor
Author
Will do as a follow-up, the linkify upgrade may take a tiny bit longer due to some parser changes. 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add some basic linkify-matrix tests before upgrading the dependencies to a newer version.
This PR currently has no changelog labels, so will not be included in changelogs.
A reviewer can add one of:
T-Deprecation,T-Enhancement,T-Defect,T-Taskto indicate what type of change this is, or addType: [enhancement/defect/task]to the description and I'll add them for you.Preview: https://619ff61d2458c7374904f648--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.