This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Fix Scroll to most recent messages button not working when a message is highlighted#7333
Closed
aaronraimist wants to merge 1 commit into
Closed
Fix Scroll to most recent messages button not working when a message is highlighted#7333aaronraimist wants to merge 1 commit into
aaronraimist wants to merge 1 commit into
Conversation
…is highlighted Signed-off-by: Aaron Raimist <aaron@raim.ist>
andybalaam
added
the
T-Defect
germain-gg
reviewed
Dec 10, 2021
Contributor
germain-gg
left a comment
germain-gg
left a comment
There was a problem hiding this comment.
Happy to go ahead with that if clicking on jump to live still clears the event ID from the URL
Contributor
Author
|
It does not. Looks like this regressed in #7003. The Firefox debugger seems to be very broken so I can't quite figure out the solution. Perhaps you can take a look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#19813
Here's what your changelog entry will look like:
🐛 Bug Fixes
Preview: https://61b35ab9fc8c952fd8a852b9--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.