This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Show message redactions as black event tiles#739
Merged
Conversation
added 7 commits
March 3, 2017 15:42
It's curious, however, that a continuation occured after a redacted event, given that the event shouldn't have a sender
dbkr
suggested changes
Mar 8, 2017
| module.exports.haveTileForEvent = function(e) { | ||
| if (e.isRedacted()) return false; | ||
| // Only messages have a tile (black-rectangle) if redacted | ||
| if (e.isRedacted() && e.getType() !== 'm.room.message') return false; |
Member
There was a problem hiding this comment.
We should probably display tiles for all redacted events. Presumably this won't really require anything extra, as long as we use the same style for now?
Member
There was a problem hiding this comment.
Conclusion is to do a separate PR for other event types (where we probably just skip rendering the specific tile altogether): https://matrix.to/#/!DdJkzRliezrwpNebLk:matrix.org/$148905194216eubJF:ldbco.de
dbkr
approved these changes
Mar 9, 2017
martindale
pushed a commit
to FabricLabs/matrix-react-sdk
that referenced
this pull request
Dec 8, 2018
add new examples, to be expanded into a post
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#1082
Looks like (with element-hq/element-web#3379):
