Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Add onClick to permalinks to route within Riot#744

Merged
ara4n merged 3 commits into
developfrom
luke/add-onclick-permalinks
Mar 9, 2017
Merged

Add onClick to permalinks to route within Riot#744
ara4n merged 3 commits into
developfrom
luke/add-onclick-permalinks

Conversation

@lukebarnard1
Copy link
Copy Markdown
Contributor

@lukebarnard1 lukebarnard1 commented Mar 8, 2017

Copy link
Copy Markdown
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm

Comment thread src/components/views/rooms/EventTile.js Outdated
},

onPermalinkClicked: function(e) {
// This allows the permalink to be open in a new tab/window or copied as
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

opened

@dbkr dbkr assigned lukebarnard1 and unassigned dbkr Mar 8, 2017
@ara4n ara4n merged commit 7fb9ce2 into develop Mar 9, 2017
@ara4n
Copy link
Copy Markdown
Member

ara4n commented Mar 9, 2017

merging this as the current misbehaviour of chucking you out of the app is driving me mad!

martindale pushed a commit to FabricLabs/matrix-react-sdk that referenced this pull request Dec 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants