Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Copy bubble layout changes to timelineCard#7527

Merged
toger5 merged 3 commits into
developfrom
toger5/timelineCard_bubbles
Jan 13, 2022
Merged

Copy bubble layout changes to timelineCard#7527
toger5 merged 3 commits into
developfrom
toger5/timelineCard_bubbles

Conversation

@toger5
Copy link
Copy Markdown
Contributor

@toger5 toger5 commented Jan 12, 2022

Fixes: element-hq/element-web#20511
Basically the same then: #7478
(the idea is to use this class for the ThreadView as well. Then there is no code duplication anymore.)
image


This PR currently has no changelog labels, so will not be included in changelogs.

A reviewer can add one of: T-Deprecation, T-Enhancement, T-Defect, T-Task to indicate what type of change this is, or add Type: [enhancement/defect/task] to the description and I'll add them for you.

Preview: https://61df14e07bcada0a9705ede4--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.

@toger5 toger5 requested a review from a team as a code owner January 12, 2022 16:08
@toger5 toger5 changed the title Copy bublle layout changes to timelineCard Copy bubble layout changes to timelineCard Jan 12, 2022
Copy link
Copy Markdown
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

Comment thread src/components/views/right_panel/TimelineCard.tsx Outdated
@toger5 toger5 requested a review from t3chguy January 12, 2022 16:18
Comment thread src/components/views/right_panel/TimelineCard.tsx Outdated
Comment thread src/components/views/right_panel/TimelineCard.tsx Outdated
@toger5 toger5 requested a review from t3chguy January 12, 2022 17:59
@toger5 toger5 merged commit 78ff685 into develop Jan 13, 2022
@toger5 toger5 deleted the toger5/timelineCard_bubbles branch January 13, 2022 09:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make bubbles layout work for right panel timeline

2 participants