Fix @name:server links to not open new tab

[toger5]

These links should be converted to href="#/something/something"` so that they are opened inside element and not inside a new tab.

---

Here's what your changelog entry will look like:

🐛 Bug Fixes

• Fix @name:server links to not open new tab (#7550). Contributed by @toger5.

Preview: https://61e1c220d8aa354e176044e7--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.

[t3chguy]

I don't think this is the right approach, this means that right click - copy link will now no longer copy the matrix.to link which it should.
There should be an onclick handler on this link to intercept it. e.g

matrix-react-sdk/src/linkify-matrix.ts

Lines 167 to 188 in ec6c1b8

	case Type.UserId:
	return {
	// @ts-ignore see https://linkify.js.org/docs/options.html
	click: function(e) {
	onUserClick(e, href);
	},
	};
	case Type.RoomAlias:
	return {
	// @ts-ignore see https://linkify.js.org/docs/options.html
	click: function(e) {
	onAliasClick(e, href);
	},
	};
	case Type.GroupId:
	return {
	// @ts-ignore see https://linkify.js.org/docs/options.html
	click: function(e) {
	onGroupClick(e, href);
	},
	};
	}

[toger5]

I was wondering about the same thing now as well (while reading more about linkifyjs)
So debugging why the onclick handler is not set up correctly would be the right approach then?
Then there is a bug in sending: https://matrix.to/#/@toger5:matrix.org in a matrix room which gets converted to: href="#/user/@toger5:matrix.org" and then results in: https://develop.element.io/#/user/@toger5:matrix.org when copying the link (using the firefox right click menu)

[t3chguy]

So debugging why the onclick handler is not set up correctly would be the right approach then?

Yup ideally

[toger5]

Then there is a bug in sending: https://matrix.to/#/@toger5:matrix.org in a matrix room which gets converted to: href="#/user/@toger5:matrix.org" and then results in: https://develop.element.io/#/user/@toger5:matrix.org when copying the link (using the firefox right click menu)

And this is also the wrong behaviour right? we want the right click to copy: https://matrix.to/#/@toger5:matrix.org

[t3chguy]

Yeah

[toger5]

Thanks for the input. This issue will be tackled in a different pr with a better approach!