Improve the text version of a location message#7554
Conversation
andybalaam
added
the
T-Task
| return `Shared location "${description}" (${uri} at ${date})`; | ||
| } else { | ||
| return `Location ${uri} at ${date}`; | ||
| return `Shared their location (${uri} at ${date})`; |
There was a problem hiding this comment.
this should probably be internationalised, no?
There was a problem hiding this comment.
I'd be very jarred if I send a location on Web in Polish and open it on my phone and some random english text is shown instead
There was a problem hiding this comment.
No, it's intentionally not internationalised, because the reader will be on a different client, with potentially-different locale.
There was a problem hiding this comment.
This is the text description of the event, right? I don't really feel like Shared their location... is a good text representation.
I already have a PR (#7552) to fix the notifications
There was a problem hiding this comment.
This is the fallback textual description, we normally internationalise them. Like if you're sending a file without a name we say Attachment in your own language, not always in English.
There was a problem hiding this comment.
OK, thanks I was obviously misinformed. Sorry for missing your change Simon, it looks much better!
There was a problem hiding this comment.
OK, thanks I was obviously misinformed. Sorry for missing your change Simon, it looks much better!
No worries!
|
Closing in favour of #7552. |
3 participants
This change is marked as an internal change (Task), so will not be included in the changelog.
Preview: https://61e539158eef0b36a9256ea2--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.