Add a warning to the console to discourage attacks and encourage contributing#7608
Add a warning to the console to discourage attacks and encourage contributing#7608SimonBrandner wants to merge 3 commits into
Conversation
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
github-actions
Bot
added
the
T-Enhancement
| if (this.accountPasswordTimer !== null) clearTimeout(this.accountPasswordTimer); | ||
| } | ||
|
|
||
| private onKeyDown = (event: KeyboardEvent): void => { |
There was a problem hiding this comment.
you can open the devtools in many more ways, e.g Inspect Element, browser's View menu etc
So I don't think this is fool-proof enough and a good scammer could just instruct them to use one of those instead of the keyboard shortcut to avoid this warning
There was a problem hiding this comment.
Args, I am notan idiot... Though I have no idea how to detect the console in another way...
There was a problem hiding this comment.
Could do it on viewport resize (unreliable way of detecting console state) but that's still far from ideal, maybe make a localStorage flag which enables debug log and otherwise hide non-critical/bug console.logs.
There was a problem hiding this comment.
Not, only I am an idiot but I am also blind 🤦♂️
Thanks, will have a look
|
Closing in favour of #7673 |
2 participants
Fixes element-hq/element-web#2803
Type: enhancement
Here's what your changelog entry will look like:
✨ Features