This repository was archived by the owner on Sep 11, 2024. It is now read-only.
unit test basic paths in UserInfo#7740
Merged
Merged
Conversation
added 2 commits
February 8, 2022 11:58
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
kerryarchibald
added
the
T-Task
t3chguy
reviewed
Feb 8, 2022
|
|
||
| it('renders user info', () => { | ||
| const component = getComponent(); | ||
| expect(component.find(BasicUserInfo).length).toBeTruthy(); |
Member
There was a problem hiding this comment.
Can we use "BasicUserInfo" instead of having to export it?
Contributor
Author
There was a problem hiding this comment.
good idea, done
t3chguy
approved these changes
Feb 8, 2022
Member
t3chguy
left a comment
t3chguy
left a comment
There was a problem hiding this comment.
LGTM other than exporting a component only for tests when you can find components by name too
Signed-off-by: Kerry Archibald <kerrya@element.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#7687
This change is marked as an internal change (Task), so will not be included in the changelog.
Preview: https://62025dd78d8a9ab0a84b53fb--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.