Unit test tsc fixes part 15#8104
Conversation
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
kerryarchibald
added
the
T-Task
Codecov Report
@@ Coverage Diff @@
## develop #8104 +/- ##
========================================
Coverage 26.71% 26.71%
========================================
Files 872 872
Lines 52206 52206
Branches 13230 13230
========================================
Hits 13946 13946
Misses 38260 38260 |
turt2live
left a comment
turt2live
left a comment
There was a problem hiding this comment.
generally seems fine - thank you! If importing the components explodes violently, merge without changing it. I don't expect that they will explode, however.
|
|
||
| const _DateSeparator = sdk.getComponent("views.messages.DateSeparator"); | ||
| const DateSeparator = TestUtils.wrapInMatrixClientContext(_DateSeparator); | ||
| const DateSeparator = sdk.getComponent("views.messages.DateSeparator"); |
There was a problem hiding this comment.
We should be able to import this (makes de-skinning a lot easier)
There was a problem hiding this comment.
yay! i hate these
|
|
||
| const _MPollBody = sdk.getComponent("views.messages.MPollBody"); | ||
| const MPollBody = TestUtils.wrapInMatrixClientContext(_MPollBody); | ||
| const MPollBody = sdk.getComponent("views.messages.MPollBody"); |
|
@turt2live unfortunately importing those components breaks the tests, so I'll leave that out of this change. |
|
It'll be because skinning is terrible, so would recommend waiting for that system to just leave (which will swing by and fix it anyhow) |
2 participants
Huge diff due to giant snapshot in MPollBody - a wrapper was removed from the snapshot, meaning every line has changed indent and confused github.
This PR currently has no changelog labels, so will not be included in changelogs.
A reviewer can add one of:
T-Deprecation,T-Enhancement,T-Defect,T-Taskto indicate what type of change this is, or addType: [enhancement/defect/task]to the description and I'll add them for you.Preview: https://pr8104--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.