This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Fix soft crash around the thread panel in degraded mode#8261
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #8261 +/- ##
===========================================
- Coverage 28.60% 28.60% -0.01%
===========================================
Files 862 862
Lines 49788 49789 +1
Branches 12680 12681 +1
===========================================
Hits 14241 14241
- Misses 35547 35548 +1
|
germain-gg
approved these changes
Apr 8, 2022
germain-gg
suggested changes
Apr 8, 2022
Contributor
germain-gg
left a comment
germain-gg
left a comment
There was a problem hiding this comment.
The roomId is not unique. If you switch to "my threads" only, it'd have the same key as for all room threads
germain-gg
approved these changes
Apr 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#21719
This PR currently has no changelog labels, so will not be included in changelogs.
Add one of:
T-Deprecation,T-Enhancement,T-Defect,T-Taskto indicate what type of change this is plusX-Breaking-Changeif it's a breaking change.Preview: https://pr8261--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.