This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Live location sharing - beacon map in timeline#8286
Merged
Conversation
added 5 commits
April 11, 2022 19:26
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
kerryarchibald
added
the
T-Task
Codecov Report
@@ Coverage Diff @@
## develop #8286 +/- ##
===========================================
+ Coverage 29.51% 29.54% +0.02%
===========================================
Files 870 871 +1
Lines 49965 49986 +21
Branches 12708 12715 +7
===========================================
+ Hits 14747 14767 +20
- Misses 35218 35219 +1
|
turt2live
approved these changes
Apr 12, 2022
| // eg thread and main timeline, reply | ||
| // maplibregl needs a unique id to attach the map instance to | ||
| const useUniqueId = (eventId: string): string => { | ||
| const [id, setId] = useState(`${eventId}_${Math.random().toString(16).slice(2, 10)}`); |
Member
There was a problem hiding this comment.
we do have a random string utility too, fwiw
added 2 commits
April 12, 2022 10:03
Signed-off-by: Kerry Archibald <kerrya@element.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only visible behind a labs flag.
Renders a map in the timeline for beacon_info events, renders fallback image for stopped and loading beacons.
More UI incoming, this is a step toward #8285
This change is marked as an internal change (Task), so will not be included in the changelog.
Preview: https://pr8286--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.