Fix fallback value for missing invite power level#8335
Conversation
|
This was basically just me noticing #8297 and "amending" it. A different code location may also need to be changed to render the power levels correctly in the room setting. |
Codecov Report
@@ Coverage Diff @@
## develop #8335 +/- ##
========================================
Coverage 30.01% 30.01%
========================================
Files 879 879
Lines 50089 50089
Branches 12746 12746
========================================
Hits 15036 15036
Misses 35053 35053
|
robintown
left a comment
robintown
left a comment
There was a problem hiding this comment.
Also needs to be changed in RolesRoomSettingsTab
The spec was recently amended to document that invites actually fall back to a default of 0, rather than 50 (since this is what Synapse was doing all along): matrix-org/matrix-spec#1021
|
the tests are definitively unhappy as well, despite trying to re-run them. (please also don't force push after review is given - it makes re-review take longer) |
|
Good spot @robintown |
|
The spec document still says 50 which doesn't help
|
|
Yeah, I don't think there's a mechanism for amending existing spec releases, so the online spec will only be updated with the next release. If there's something simple I can do about the tests (I had a look before, didn't see how the failures could be related) let me know, otherwise it would be nice if sbd. else could take this over. |
|
looks like tests were an outdated branch of sorts |
The spec was recently amended to document that invites actually fall back to a default of 0, rather than 50 (since this is what Synapse was doing all along): matrix-org/matrix-spec#1021
4 participants
The spec was recently amended to document that invites actually fall back to a default of 0, rather than 50 (since this is what Synapse was doing all along): matrix-org/matrix-spec#1021
Notes: Fix a bug where the required power level for inviting somebody would be shown as 'Moderator' when in fact every regular user with power level >= 0 could send an invite.
Signed-off-by: Jonas Platte jplatte+git@posteo.de
This PR currently has no changelog labels, so will not be included in changelogs.
Add one of:
T-Deprecation,T-Enhancement,T-Defect,T-Taskto indicate what type of change this is plusX-Breaking-Changeif it's a breaking change.Preview: https://pr8335--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.