This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Write tests for message right-click context menu#8532
Merged
SimonBrandner merged 11 commits intoMay 11, 2022
Merged
Conversation
SimonBrandner
added
the
T-Task
SimonBrandner
force-pushed
the
SimonBrandner/task/right-click-tests
branch
from
8749f4f to
519ca02
Compare
SimonBrandner
force-pushed
the
SimonBrandner/task/right-click-tests
branch
from
519ca02 to
acc4bed
Compare
SimonBrandner
force-pushed
the
SimonBrandner/task/right-click-tests
branch
from
acc4bed to
67e4b45
Compare
SimonBrandner
force-pushed
the
SimonBrandner/task/right-click-tests
branch
from
67e4b45 to
bc5a837
Compare
SimonBrandner
force-pushed
the
SimonBrandner/task/right-click-tests
branch
from
bc5a837 to
9ba60f6
Compare
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
SimonBrandner
force-pushed
the
SimonBrandner/task/right-click-tests
branch
from
9ba60f6 to
b73dd49
Compare
robintown
suggested changes
May 10, 2022
Member
robintown
left a comment
robintown
left a comment
There was a problem hiding this comment.
Great to have more coverage of this 👍
Member
|
Oops, you get double the reviews :D |
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Contributor
Author
|
Sorry for quite a few dumb mistakes in this one... |
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
…sk/right-click-tests
kerryarchibald
approved these changes
May 11, 2022
Contributor
kerryarchibald
left a comment
kerryarchibald
left a comment
There was a problem hiding this comment.
LGTM, thanks for working on this!
robintown
approved these changes
May 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#21815
Based on #8527
This change is marked as an internal change (Task), so will not be included in the changelog.