Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

new message composer design#8733

Closed
chagai95 wants to merge 1 commit into
matrix-org:developfrom
chagai95:new-message-composer-design
Closed

new message composer design#8733
chagai95 wants to merge 1 commit into
matrix-org:developfrom
chagai95:new-message-composer-design

Conversation

@chagai95
Copy link
Copy Markdown
Contributor

@chagai95 chagai95 commented Jun 1, 2022

This is the new design, I guess you can just change the default colors (maybe to make it invisible?) if you don't like it, but it will be nice to have as a config.
image

Signed-off-by: Chagai Friedlander chagai.friedlander@aarenet.com

thanks to @tomtom-78


Here's what your changelog entry will look like:

✨ Features

@chagai95 chagai95 requested a review from a team as a code owner June 1, 2022 12:07
@robintown
Copy link
Copy Markdown
Member

@chagai95 Could you please explain what problems this exists to solve, or maybe link this to relevant issues? This will help the design team to more rapidly engage with what you're proposing, understand the context of your changes, and suggest any improvements or decline any changes.

The composer is already undergoing a redesign at #8578 as well.

Copy link
Copy Markdown
Contributor

@germain-gg germain-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As Robin mentioned we're currently working on the composer interface. This PR will probably conflict with some of the changes there.

We will be going ahead with the update to make the composer more visible. We can keep this PR open if you believe the changes we're making do not address your current concerns

@turt2live turt2live requested a review from a team June 1, 2022 15:42
@amshakal amshakal requested review from niquewoodhouse and removed request for a team June 1, 2022 15:55
@chagai95
Copy link
Copy Markdown
Contributor Author

chagai95 commented Jun 1, 2022

Hey, i just thought this is an easy fix and I created a PR, I think the other solution does not have a different background color is that something design would approve?

@MadLittleMods MadLittleMods added Z-Community-PR Issue is solved by a community member's PR T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements labels Jun 1, 2022
@turt2live
Copy link
Copy Markdown
Member

ftr, sent this up for design review to compare with the other composer experiments we have ongoing. The composer is quite an important part of the app in my opinion, so any feedback (particularly feedback that shows up as a PR) is immensely appreciated as it helps identify what users are worried about with the composer.

@andybalaam
Copy link
Copy Markdown
Member

Thank you for the contribution but we are following different design directions.

@andybalaam andybalaam closed this Jul 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-Community-PR Issue is solved by a community member's PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants