This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Remove an obsolete style declaration of .mx_ReplyChain_show#8743
Merged
Conversation
It was added with https://github.com/matrix-org/matrix-react-sdk/pull/6291/files#diff-11808ff6468e6efa5982f414119fcc8a3a3eea4090b1a4ebda8ed6eae732418aR163 It has not been effective for unknown period, and since the layout of the area has changed, it should be able to be safely removed. Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
github-actions
Bot
added
the
T-Task
weeman1337
approved these changes
Jun 2, 2022
Contributor
weeman1337
left a comment
weeman1337
left a comment
There was a problem hiding this comment.
Thanks for your contribution!
Tested, works 👍
Contributor
Author
|
Removing it also makes it possible to fix the large pill (with a long display name) alignment 😃 |
Contributor
|
@luixxiul can you merge |
Contributor
Author
|
@weeman1337 Done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was added with https://github.com/matrix-org/matrix-react-sdk/pull/6291/files#diff-11808ff6468e6efa5982f414119fcc8a3a3eea4090b1a4ebda8ed6eae732418aR163 (#6291). It has not been effective for unknown period, and since the layout of the area has changed from flexbox/grid for order property, it should be able to be safely removed.
type: task
Signed-off-by: Suguru Hirahara luixxiul@users.noreply.github.com
This change is marked as an internal change (Task), so will not be included in the changelog.