This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Set common width, white-space, and display values to MessageTimestamp#8818
Merged
Conversation
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
- Unset display and width value of timestamp on pinned messages card Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
…ize setting Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
- GroupLayout is modern layout, not IRC layout Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
github-actions
Bot
added
Z-Community-PR
luixxiul
commented
Jun 12, 2022
| position: initial; | ||
| font-size: $font-14px; | ||
| opacity: 1.0; | ||
| color: $event-timestamp-color; |
Contributor
Author
There was a problem hiding this comment.
This is redundant as specified with https://github.com/matrix-org/matrix-react-sdk/pull/8818/files#diff-ee6630d9ea69841b23949b052300770cf30db1afe7d269d4f4e769ef49f346b5R20.
| Before | After |
|---|---|
 |
 |
luixxiul
commented
Jun 12, 2022
| } | ||
|
|
||
| .mx_MessageTimestamp { | ||
| font-size: $font-12px; |
Contributor
Author
There was a problem hiding this comment.
luixxiul
commented
Jun 12, 2022
| max-width: 80px; | ||
| width: auto; | ||
| font-size: $font-12px; | ||
| max-width: var(--MessageTimestamp-max-width); |
Contributor
Author
There was a problem hiding this comment.
$MessageTimestamp_width is enabled here.
| Before | After |
|---|---|
 |
 |
luixxiul
commented
Jun 12, 2022
| .mx_MessageTimestamp { | ||
| font-size: $font-10px; | ||
| } | ||
|
|
luixxiul
commented
Jun 12, 2022
|
|
||
| .mx_MessageTimestamp { | ||
| top: 2px; // Align with mx_EventTile_content | ||
| position: absolute; // for IRC layout |
luixxiul
commented
Jun 12, 2022
| line-height: inherit; | ||
| color: $secondary-content; | ||
| display: unset; | ||
| width: unset; // Cancel the default width value |
luixxiul
commented
Jun 12, 2022
| color: $event-timestamp-color; | ||
| font-size: $font-10px; | ||
| font-variant-numeric: tabular-nums; | ||
| display: block; // enable the width setting below |
Contributor
Author
There was a problem hiding this comment.
Because width declaration below is supposed to be enabled by default.
luixxiul
commented
Jun 12, 2022
| .mx_MessageTimestamp { | ||
| width: unset; // Cancel the default width | ||
| max-width: var(--MessageTimestamp-max-width); | ||
| } |
dbkr
approved these changes
Jun 16, 2022
…into MessageTimestamp
luixxiul
commented
Jun 16, 2022
Contributor
Author
There was a problem hiding this comment.
Contributor
Author
|
Fixed the conflict. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR sets common width, white-space, and display value to
mx_MessageTimestamp, adding the class name tomx_PinnedEventTile_timestamp.type: task
Signed-off-by: Suguru Hirahara luixxiul@users.noreply.github.com
This change is marked as an internal change (Task), so will not be included in the changelog.