Improve _IRCLayout.scss to remove space between the avatar and info text by luixxiul · Pull Request #8858 · matrix-org/matrix-react-sdk

luixxiul · 2022-06-17T09:48:08Z

This PR organizes style rules on _IRCLayout.scss to clarify the structure.

Before	After

type: task

Here's what your changelog entry will look like:

🐛 Bug Fixes

Improve _IRCLayout.scss to remove space between the avatar and info text (#8858). Contributed by @luixxiul.

luixxiul · 2022-06-18T01:17:05Z

-            min-width: $MessageTimestamp_width;
-        }
-
+    .mx_EventTile[data-layout=irc] {


:not() can increase the specificity of a rule, therefore including .mx_EventTile by .mx_IRCLayout seems to conflict with :not([data-layout=bubble]) and has not been quite enough without [data-layout=irc].

luixxiul · 2022-06-25T01:58:20Z

        .mx_ReactionsRow {
-            padding-left: 0;
-            padding-right: 0;
+            margin-inline: 0;


This works but it is redundant- removing the inline margin declaration from _EventTile.scss looks straightforward.

Addressed with #8891

turt2live

clearing code review while draft

(@luixxiul please avoid converting things to drafts after they've been opened - if further work is needed, it's better to close and reopen the PR)

luixxiul · 2022-06-30T02:33:47Z

Do you mind if I would ask the reason why converting to draft has to be avoided?

turt2live · 2022-06-30T02:45:54Z

it ends up skewing our PR review latency statistics, and confuses the team trying to review the PR.

Opening a PR as a draft is fine, though once marked "ready for review" the assumption is that it's ready for review - it should not be converted back to draft as we cannot clear the code review request without manual intervention.

luixxiul · 2022-06-30T02:50:58Z

I understood.

Is it not possible for admins to disable converting back something to draft? Otherwise a PR template should mention that at least, IMHO. Not everyone knows how PR review is conducted.

turt2live · 2022-06-30T03:03:24Z

we're working on PR review guidance, and are fixing our contributing guidelines, though both are a bit slow (sorry).

…le]) Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

…moving a default declaration Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

luixxiul · 2023-02-20T08:14:45Z

Closing as stale

github-actions Bot added Z-Community-PR Issue is solved by a community member's PR T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems labels Jun 17, 2022

github-actions Bot deployed to Netlify June 17, 2022 09:52 View deployment

luixxiul marked this pull request as ready for review June 17, 2022 10:08

luixxiul requested a review from a team as a code owner June 17, 2022 10:08

github-actions Bot deployed to Netlify June 17, 2022 10:13 View deployment

luixxiul commented Jun 18, 2022

View reviewed changes

luixxiul mentioned this pull request Jun 24, 2022

Reactions are misaligned in IRC layout element-hq/element-web#22644

Closed

luixxiul changed the title ~~Improve _IRCLayout.scss to remove space between avatar and info text~~ Remove space between avatar and info text, and inline start (left) margin from the reactions row on IRC layout Jun 24, 2022

luixxiul commented Jun 25, 2022

View reviewed changes

luixxiul changed the title ~~Remove space between avatar and info text, and inline start (left) margin from the reactions row on IRC layout~~ Improve _IRCLayout.scss to remove space between the avatar and info text Jun 26, 2022

github-actions Bot deployed to Netlify June 26, 2022 03:21 View deployment

luixxiul marked this pull request as draft June 29, 2022 17:55

github-actions Bot deployed to Netlify June 29, 2022 18:13 View deployment

turt2live reviewed Jun 29, 2022

View reviewed changes

github-actions Bot deployed to Netlify July 3, 2022 08:27 View deployment

github-actions Bot deployed to Netlify July 7, 2022 02:51 View deployment

github-actions Bot deployed to Netlify July 7, 2022 08:44 View deployment

github-actions Bot deployed to Netlify July 7, 2022 12:14 View deployment

github-actions Bot deployed to Netlify July 12, 2022 14:49 View deployment

github-actions Bot deployed to Netlify July 15, 2022 07:32 View deployment

github-actions Bot deployed to Netlify July 20, 2022 15:36 View deployment

luixxiul added 4 commits July 26, 2022 02:28

Specify the data-layout=irc explicitly against :not([data-layout=bubb…

48db20a

…le]) Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

Include mx_EventTile_info in mx_EventTile[data-layout=irc]

3dfe83a

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

Move declarations directly under mx_EventTile[data-layout=irc] up, re…

1881967

…moving a default declaration Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

Tidy up mx_EventTile:hover etc.

ac624b4

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

luixxiul added 6 commits July 26, 2022 02:31

Use a spacing variable

cbe4171

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

Sort by order properties

eedc52a

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

Remove a redundant declaration

5bbb8d3

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

Separate selectors

07e82ff

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

Merge style declarations - flex-shrink

8130210

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

Remove a redundant declaration about padding

d31d357

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

luixxiul closed this Feb 20, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Improve _IRCLayout.scss to remove space between the avatar and info text#8858

Improve _IRCLayout.scss to remove space between the avatar and info text#8858
luixxiul wants to merge 10 commits into
matrix-org:developfrom
luixxiul:IRCLayout

luixxiul commented Jun 17, 2022 •

edited by github-actions Bot

Loading

Uh oh!

luixxiul Jun 18, 2022 •

edited

Loading

Uh oh!

luixxiul Jun 25, 2022 •

edited

Loading

Uh oh!

turt2live left a comment

Uh oh!

luixxiul commented Jun 30, 2022

Uh oh!

turt2live commented Jun 30, 2022

Uh oh!

luixxiul commented Jun 30, 2022 •

edited

Loading

Uh oh!

turt2live commented Jun 30, 2022

Uh oh!

luixxiul commented Feb 20, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

luixxiul commented Jun 17, 2022 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🐛 Bug Fixes

Uh oh!

luixxiul Jun 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

luixxiul Jun 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

turt2live left a comment

Choose a reason for hiding this comment

Uh oh!

luixxiul commented Jun 30, 2022

Uh oh!

turt2live commented Jun 30, 2022

Uh oh!

luixxiul commented Jun 30, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

turt2live commented Jun 30, 2022

Uh oh!

luixxiul commented Feb 20, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

luixxiul commented Jun 17, 2022 •

edited by github-actions Bot

Loading

luixxiul Jun 18, 2022 •

edited

Loading

luixxiul Jun 25, 2022 •

edited

Loading

luixxiul commented Jun 30, 2022 •

edited

Loading