Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Remove mx_GroupLayout#8876

Merged
SimonBrandner merged 1 commit into
matrix-org:developfrom
luixxiul:mx_GroupLayout
Jun 25, 2022
Merged

Remove mx_GroupLayout#8876
SimonBrandner merged 1 commit into
matrix-org:developfrom
luixxiul:mx_GroupLayout

Conversation

@luixxiul
Copy link
Copy Markdown
Contributor

@luixxiul luixxiul commented Jun 21, 2022

The class name is no longer used for styling.

context: _GroupLayout.scss had been used to style EventTile of [data-layout=group], and the styles on that file were merged with _EventTile.scss.

Signed-off-by: Suguru Hirahara luixxiul@users.noreply.github.com

type: task


This change is marked as an internal change (Task), so will not be included in the changelog.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
@github-actions github-actions Bot added Z-Community-PR Issue is solved by a community member's PR T-Task Refactoring, enabling or disabling functionality, other engineering tasks labels Jun 21, 2022
@luixxiul luixxiul marked this pull request as ready for review June 21, 2022 12:26
@luixxiul luixxiul requested a review from a team as a code owner June 21, 2022 12:26
private get messagePanelClassNames(): string {
return classNames("mx_RoomView_messagePanel", {
mx_IRCLayout: this.state.layout === Layout.IRC,
mx_GroupLayout: this.state.layout === Layout.Group,
Copy link
Copy Markdown
Contributor Author

@luixxiul luixxiul Jun 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was introduced for search result in bubble message layout here with #7648.

Copy link
Copy Markdown
Contributor

@SimonBrandner SimonBrandner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@SimonBrandner SimonBrandner merged commit 4b2a922 into matrix-org:develop Jun 25, 2022
@luixxiul luixxiul deleted the mx_GroupLayout branch June 25, 2022 12:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

T-Task Refactoring, enabling or disabling functionality, other engineering tasks Z-Community-PR Issue is solved by a community member's PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants