This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Remove unused code left over from the old search#8947
Merged
justjanne merged 5 commits intoJun 30, 2022
Conversation
t3chguy
reviewed
Jun 30, 2022
Member
t3chguy
left a comment
There was a problem hiding this comment.
I think all the Runtime filtering stuff can be removed also, including stuff like
matrix-react-sdk/src/stores/room-list/RoomListStore.ts
Lines 564 to 571 in 2a396a4
Contributor
Author
Are you sure? It looks like that’s used for filtering by space |
Member
|
Spaces use Prefiltering, not Runtime filtering, that else clause will never be entered to my knowledge |
t3chguy
reviewed
Jun 30, 2022
Member
t3chguy
left a comment
There was a problem hiding this comment.
Is FilterKind used any more? Or at least is Runtime filterkind used anymore?
t3chguy
reviewed
Jun 30, 2022
Member
t3chguy
left a comment
There was a problem hiding this comment.
I think all the filter handling in Algorithm.ts is also now dead
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type: Task
Closes: element-hq/element-web#22696
This change is marked as an internal change (Task), so will not be included in the changelog.