don't show rooms when they're ignored#8988
Conversation
Signed-off-by: jesopo <github@lolnerd.net>
| } | ||
|
|
||
| const cli = MatrixClientPeg.get(); | ||
| if (cli.getIgnoredInvites()?.ignored_rooms?.includes(room.roomId) ?? false) { |
There was a problem hiding this comment.
surely this should also be checking the room is an invite, in case you joined it via a client which doesn't support that MSC. This specifically says getIgnoredInvites
There was a problem hiding this comment.
yes, this is true, but there's ongoing discussion about whether we just want to ignore invites, or ignore rooms wholesale; the idea being someone might want to ignore a room they're already in. i should have made that clear in the body of this PR
There was a problem hiding this comment.
I'm surprised this is the shape it is, ignoring users happens at the server level, why wouldn't ignoring rooms work the same? With the way it is currently structured, your /sync may include a billion rooms which you ignore at the UI level.
There was a problem hiding this comment.
I believe that we should focus on ignoring invites for the time being.
There was a problem hiding this comment.
in that case; i assume i'm going to have to hand something like cause off to VisibilityProvider
There was a problem hiding this comment.
Or move it into the js-sdk getVisibleRooms
robintown
requested review from
a team,
andybalaam and
germain-gg
and removed request for
a team,
SimonBrandner,
andybalaam,
duxovni,
germain-gg and
robintown
|
Please re-request review from the element-web team when this is no longer a draft |
|
Upgraded to the latest API (plus applied feedback) in #9255. |
4 participants
based on #8983. will want an additional UI change to warn users that they're looking at an ignored room (with an option to unignore) if they click on a room link for an ignored room
This PR currently has none of the required changelog labels.
Add one of:
T-Deprecation,T-Enhancement,T-Defect,T-Taskto indicate what type of change this is plusX-Breaking-Changeif it's a breaking change.