Remove old Room Directory

[justjanne]

Type: Task
Fixes: element-hq/element-web#22846

---

This change is marked as an internal change (Task), so will not be included in the changelog.

[turt2live]

this appears to be a fairly massive change for the app, so would appreciate explicit review from the product and/or design team.

[t3chguy]

Is this case covered in the spotlight tests?

[justjanne]

Finding public rooms is in spotlight's tests.

But sure, I could add a test that creates a private room, publishes it via the UI, and then tries to find it, just for completeness' sake.

[kittykat]

Are there any visual changes associated with this PR? Any risk of any remaining functionality breaking?

[turt2live]

The UI change would be the loss of the public room directory button (from the home view). It's less of a risk than what it used to be, but also still fairly significant.

[kittykat]

Changing the home screen is a more complicated issue which needs product thinking. Can that button link to this view instead of the old one?

[t3chguy]

@kittykat that is already what happens, all interactions which went to the dialog being removed are re-routed to Spotlight-in-the-explore-state

[t3chguy]

Looks sane but CI is generally unhappy with it

[kittykat]

Looks fine from product pov as all links to the directory have been updated

[germain-gg]

Superseeded by #9605