This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Add test to check block start padding of a continued event tile on modern/group layout#9065
Closed
luixxiul wants to merge 0 commit into
Closed
Add test to check block start padding of a continued event tile on modern/group layout#9065luixxiul wants to merge 0 commit into
luixxiul wants to merge 0 commit into
Conversation
github-actions
Bot
added
Z-Community-PR
luixxiul
changed the title
Member
|
Please could you resolve the conflicts and then ping me to merge? |
kerryarchibald
suggested changes
Jul 18, 2022
Contributor
kerryarchibald
left a comment
kerryarchibald
left a comment
There was a problem hiding this comment.
Please assert the block padding is correct using a percy snapshot rather that css inspection.
| cy.get(".mx_RoomView_body .mx_EventTile").contains(".mx_EventTile[data-scroll-tokens]", "Hello Again"); | ||
|
|
||
| // Check block start padding of the second message | ||
| cy.get(".mx_EventTile[data-layout=group].mx_EventTile_continuation") |
Contributor
There was a problem hiding this comment.
This check should be captured by a percy snapshot, not explicitly checking the style. These e2e tests should be testing from the POV of the user to see that 1) things work as expected and 2) look as expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #9033
This PR adds a test to check whether block start padding of a continued event tile on modern/group layout is set to zero without
!importantflag.Signed-off-by: Suguru Hirahara luixxiul@users.noreply.github.com
type: task
Checklist
This change is marked as an internal change (Task), so will not be included in the changelog.