Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Spike AXE A11Y testing in Cypress#9111

Merged
t3chguy merged 30 commits into
developfrom
t3chguy/fix/14732
Aug 1, 2022
Merged

Spike AXE A11Y testing in Cypress#9111
t3chguy merged 30 commits into
developfrom
t3chguy/fix/14732

Conversation

@t3chguy
Copy link
Copy Markdown
Member

@t3chguy t3chguy commented Jul 27, 2022 •
edited by github-actions Bot
Loading

Fixes element-hq/element-web#14732
Requires element-hq/element-web#22948

This change is marked as an internal change (Task), so will not be included in the changelog.

@t3chguy t3chguy added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Jul 27, 2022
@t3chguy
Copy link
Copy Markdown
Member Author

t3chguy commented Jul 28, 2022 

┌─────────┬─────────────────────────┬────────────┬───────────────────────────────────────────────────────────────────────────────────────────────────────────┬───────┐
│ (index) │           id            │   impact   │                                                description                                                │ nodes │
├─────────┼─────────────────────────┼────────────┼───────────────────────────────────────────────────────────────────────────────────────────────────────────┼───────┤
│    0    │   'aria-allowed-attr'   │ 'critical' │                        "Ensures ARIA attributes are allowed for an element's role"                        │   2   │
│    1    │ 'aria-required-parent'  │ 'critical' │           'Ensures elements with an ARIA role that require parent roles are contained by them'            │   2   │
│    2    │ 'aria-valid-attr-value' │ 'critical' │                              'Ensures all ARIA attributes have valid values'                              │   1   │
│    3    │    'color-contrast'     │ 'serious'  │ 'Ensures the contrast between foreground and background colors meets WCAG 2 AA contrast ratio thresholds' │   1   │
│    4    │         'list'          │ 'serious'  │                               'Ensures that lists are structured correctly'                               │   1   │
│    5    │ 'page-has-heading-one'  │ 'moderate' │            'Ensure that the page, or at least one of its frames contains a level-one heading'             │   1   │
│    6    │        'region'         │ 'moderate' │                           'Ensures all page content is contained by landmarks'                            │   1   │
└─────────┴─────────────────────────┴────────────┴───────────────────────────────────────────────────────────────────────────────────────────────────────────┴───────┘

t3chguy added 20 commits July 28, 2022 12:12
@t3chguy
Fix NewRoomIntro breaking html/aria list rules
7347ac0
@t3chguy
Fix HeaderButtons breaking aria role semantics rules
0d1dc82
@t3chguy
missing type
c00548c
@t3chguy
Switch left panel from aside to nav and include space panel
b4b516c
@t3chguy
Give the page a main heading of the room name when viewing a room
1cc238b
@t3chguy
Use header landmark on RoomHeader
a1f4ec0
@t3chguy
Improve aria attributes on composer when autocomplete is closed
55532c9
@t3chguy
Fix aria-owns on RoomHeader
7dea9b0
@t3chguy
Give Spinner an aria role
20737ab
@t3chguy
Give server picker help button an aria label
415cb0b
@t3chguy
Improve auth aria attributes and semantics
324b899
@t3chguy
Improve heading semantics in use case selection screen
95e0066
@t3chguy
Fix autocomplete attribute to be valid
e5927b5
@t3chguy
Fix heading semantics on login page
f99f7c0
@t3chguy
Improve Cypress axe testing
ca65131
@t3chguy
Add axe tests
2e3b9bb
@t3chguy
Stop synapse after the timeline tests
0c4526f
@t3chguy
Await spinners to fade before percy snapshotting timeline tests
d8d5eac
@t3chguy
Merge branch 'develop' of github.com:matrix-org/matrix-react-sdk into…
222a024 
… t3chguy/fix/14732

� Conflicts:
�	cypress/plugins/index.ts
�	src/i18n/strings/en_EN.json
@t3chguy
Improve naming of plugin
1ff21a1
@t3chguy t3chguy marked this pull request as ready for review July 28, 2022 14:13
@t3chguy t3chguy requested a review from a team as a code owner July 28, 2022 14:13
turt2live
turt2live approved these changes Jul 29, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@t3chguy t3chguy merged commit d5db131 into develop Aug 1, 2022
@t3chguy t3chguy deleted the t3chguy/fix/14732 branch August 1, 2022 07:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@andybalaam andybalaam Awaiting requested review from andybalaam andybalaam is a code owner automatically assigned from matrix-org/element-web-reviewers

@germain-gg germain-gg Awaiting requested review from germain-gg germain-gg is a code owner automatically assigned from matrix-org/element-web-reviewers

@duxovni duxovni Awaiting requested review from duxovni duxovni is a code owner automatically assigned from matrix-org/element-web-reviewers

1 more reviewer

@turt2live turt2live turt2live approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

T-Task Refactoring, enabling or disabling functionality, other engineering tasks

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Look at Axe for a11y CI

2 participants

@t3chguy @turt2live