Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Add unit test for UserSettingsDialog#9118

Merged
kerryarchibald merged 4 commits into
developfrom
kerry/test-user-settings-dialog
Aug 1, 2022
Merged

Add unit test for UserSettingsDialog#9118
kerryarchibald merged 4 commits into
developfrom
kerry/test-user-settings-dialog

Conversation

@kerryarchibald
Copy link
Copy Markdown
Contributor

@kerryarchibald kerryarchibald commented Jul 29, 2022 •
edited by github-actions Bot
Loading

Test before upcoming changes with new device manager.

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@kerryarchibald kerryarchibald added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Jul 29, 2022
@kerryarchibald kerryarchibald requested a review from a team as a code owner July 29, 2022 11:32
@kerryarchibald kerryarchibald changed the title test UserSettingsDialog Add unit test for UserSettingsDialog Jul 29, 2022
@kerryarchibald kerryarchibald mentioned this pull request Jul 29, 2022
Merged
3 tasks
turt2live
turt2live approved these changes Jul 29, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems reasonable - thanks!

@kerryarchibald kerryarchibald enabled auto-merge (squash) August 1, 2022 06:19
@kerryarchibald kerryarchibald merged commit 05cc5f6 into develop Aug 1, 2022
@kerryarchibald kerryarchibald deleted the kerry/test-user-settings-dialog branch August 1, 2022 06:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@justjanne justjanne Awaiting requested review from justjanne justjanne is a code owner automatically assigned from matrix-org/element-web-reviewers

@duxovni duxovni Awaiting requested review from duxovni duxovni is a code owner automatically assigned from matrix-org/element-web-reviewers

1 more reviewer

@turt2live turt2live turt2live approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

T-Task Refactoring, enabling or disabling functionality, other engineering tasks

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kerryarchibald @turt2live