This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Exported filename ISO date format#9142
Closed
yaya-usman wants to merge 3 commits into
Closed
Conversation
yaya-usman
added
the
T-Enhancement
yaya-usman
requested review from
justjanne,
t3chguy and
turt2live
and removed request for
justjanne,
t3chguy and
turt2live
turt2live
suggested changes
Aug 8, 2022
| protected async downloadZIP(): Promise<string | void> { | ||
| const brand = SdkConfig.get().brand; | ||
| const filenameWithoutExt = `${brand} - Chat Export - ${formatFullDateNoDay(new Date())}`; | ||
| const filenameWithoutExt = `${brand} - ${this.room.name} - Chat Export -${formatFullDateNoDayISO(new Date())}`; |
Member
There was a problem hiding this comment.
I think we still need to consider the room name having invalid characters in it?
applies to later on as well.
Contributor
There was a problem hiding this comment.
@turt2live there is another PR which does that, I believe: #7992
Member
There was a problem hiding this comment.
We can't land this code at the moment without that code, given the safety risk we'd be taking on. It feels like it might have been split up too much?
Member
|
Thanks for the PR! Sorry it took so long to get considered. We've decided to merge the changes from this and #7992 into a single PR to ease the requirements raised by the Product team, and are closing this PR as a result. Hopefully this should mean the code goes live soon. You can see the new PR here: #9440 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A breakout PR from #8558 PR as requested by @kittykat
Here's what your changelog entry will look like:
✨ Features