fix(room service): enable the thread subscriptions extension based on server support#5618
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5618 +/- ##
==========================================
- Coverage 88.40% 88.39% -0.01%
==========================================
Files 355 355
Lines 97604 97610 +6
Branches 97604 97610 +6
==========================================
+ Hits 86282 86287 +5
+ Misses 7256 7255 -1
- Partials 4066 4068 +2 ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #5618 will improve performances by 46.86%Comparing Summary
Benchmarks breakdown
|
Hywan
requested changes
Sep 3, 2025
Member
Hywan
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks! Would love to get a test for that, it seems sensitive, thought?
Contributor
Author
|
Sure, should be fairly trivial albeit verbose to test. |
…server advertises support for it
ae4ce6e to
cc23fdc
Compare
Hywan
approved these changes
Sep 15, 2025
cc23fdc to
6289124
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise, when running against a server that doesn't support thread subscriptions, the client may falsely think that its thread subscriptions are not outdated (when receiving an empty, defaulted
ThreadSubscriptionssection in the SSS response). As a result, it would always use the store, not find most thread subscriptions, and conclude "nope, you haven't subscribed to any thread", which is wrong.(Looking for support of MSC4306 is close to what we want, which would be support of MSC4308 itself, coming as part of element-hq/synapse#18695, and that will land despite MSC4306 being already advertised, but that's good enough, since it's unlikely many servers have enabled it by default yet.)